[Jetcaster] Remove HomeState and reduces lambdas into HomeAction #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it served only as a wrapper for parameters without any additional logic - it was unstable and creating new instance each composition, therefore no skipping # Conflicts: # Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
Reduces amount of passing and potentially making mistake
mlykotom
force-pushed
the
mlykotom/jetcaster/simplify-home
branch
from
f6ec85a
to
ec5e931
Compare
simona-anomis
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Merge after #1499]