-
Notifications
You must be signed in to change notification settings - Fork 5.2k
🤖 Update Dependencies #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Update Dependencies #1574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @compose-devrel-github-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request systematically updates numerous dependencies across the project's modules, primarily affecting the libs.versions.toml
files. The goal is to bring the project up-to-date with the latest versions of core Android development libraries, build tools, and other third-party dependencies, including a change in the Compose BOM module name and the addition of new library aliases.
Highlights
- Dependency Updates: Updated versions for a wide range of libraries and tools, including Android Gradle Plugin, Kotlin, Compose BOM, Material 3, AndroidX Lifecycle, Wear Compose, Horologist, Media3, Roborazzi, and Spotless.
- Compose BOM Module Change: The module name for the Compose BOM dependency was updated from
androidx.compose:compose-bom
toandroidx.compose:compose-bom-alpha
. - New Library Aliases: Added new aliases for
androidx.media3
andhorologist
libraries in the[libraries]
section of the version catalog.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates a wide range of dependencies across multiple libs.versions.toml
files, including the central scripts/libs.versions.toml
. Key changes involve:
- Standard patch and minor version bumps for libraries like Android Gradle Plugin, Kotlin, KSP, and various AndroidX libraries.
- A significant change to the
androidx-compose-bom
, which now points toandroidx.compose:compose-bom-alpha
. This implies the project will be using an alpha Bill of Materials for Compose, which should be a deliberate choice considering potential stability implications. - Several core libraries, notably
androidx-wear-compose
(updated from1.4.1
to1.5.0-beta03
) andhorologist
(updated from0.6.23
to0.7.14-beta
), have transitioned from stable releases to beta versions in most modules (this does not apply to Jetcaster for these specific libraries as it was already on beta versions). This shift requires careful testing due to the inherent nature of beta software. - The
androidx-wear-compose-material
alias has been updated to point toandroidx.wear.compose:compose-material3
(fromcompose-material
). This is a major API migration from Material to Material 3 for Wear Compose components and will likely necessitate significant code refactoring in affected modules. - New dependencies for
media3
and additionalhorologist
artifacts (model and material3) have been introduced or updated.
Given the brief PR description ("Updated depedencies"), it's important to ensure that the implications of moving to alpha/beta versions and undertaking major migrations like Wear Material 2 to Material 3 are fully understood and planned for. Thorough testing across all affected modules is highly recommended.
androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "androidx-appcompat" } | ||
androidx-compose-animation = { module = "androidx.compose.animation:animation" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom", version.ref = "androidx-compose-bom" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom-alpha", version.ref = "androidx-compose-bom" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Compose Bill of Materials (BOM) module has been changed to androidx.compose:compose-bom-alpha
. This switch to an alpha BOM means the project will pull in pre-release versions of Compose libraries, which can be less stable and may include breaking changes. Please confirm this is intentional and aligns with the project's stability goals.
androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "androidx-appcompat" } | ||
androidx-compose-animation = { module = "androidx.compose.animation:animation" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom", version.ref = "androidx-compose-bom" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom-alpha", version.ref = "androidx-compose-bom" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Compose Bill of Materials (BOM) module has been changed to androidx.compose:compose-bom-alpha
. This switch to an alpha BOM means the project will pull in pre-release versions of Compose libraries, which can be less stable and may include breaking changes. Please confirm this is intentional and aligns with the project's stability goals.
androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "androidx-appcompat" } | ||
androidx-compose-animation = { module = "androidx.compose.animation:animation" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom", version.ref = "androidx-compose-bom" } | ||
androidx-compose-bom = { module = "androidx.compose:compose-bom-alpha", version.ref = "androidx-compose-bom" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Compose Bill of Materials (BOM) module has been changed to androidx.compose:compose-bom-alpha
. This switch to an alpha BOM means the project will pull in pre-release versions of Compose libraries, which can be less stable and may include breaking changes. Please confirm this is intentional and aligns with the project's stability goals.
androidx-tv-material = { module = "androidx.tv:tv-material", version.ref = "androidx-tv-material" } | ||
androidx-wear-compose-foundation = { module = "androidx.wear.compose:compose-foundation", version.ref = "androidx-wear-compose" } | ||
androidx-wear-compose-material = { module = "androidx.wear.compose:compose-material", version.ref = "androidx-wear-compose" } | ||
androidx-wear-compose-material = { module = "androidx.wear.compose:compose-material3", version.ref = "androidx-wear-compose-material3" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change migrates the androidx-wear-compose-material
alias to point to androidx.wear.compose:compose-material3
(from compose-material
). This is a major update from Wear Material to Wear Material 3, involving significant API differences and design system changes. Modules using these components will likely require substantial refactoring. Please ensure this migration effort is planned and accounted for.
androidx-tv-material = { module = "androidx.tv:tv-material", version.ref = "androidx-tv-material" } | ||
androidx-wear-compose-foundation = { module = "androidx.wear.compose:compose-foundation", version.ref = "androidx-wear-compose" } | ||
androidx-wear-compose-material = { module = "androidx.wear.compose:compose-material", version.ref = "androidx-wear-compose" } | ||
androidx-wear-compose-material = { module = "androidx.wear.compose:compose-material3", version.ref = "androidx-wear-compose-material3" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change migrates the androidx-wear-compose-material
alias to point to androidx.wear.compose:compose-material3
(from compose-material
). This is a major update from Wear Material to Wear Material 3, involving significant API differences and design system changes. Modules using these components will likely require substantial refactoring. Please ensure this migration effort is planned and accounted for.
gradle-versions = "0.52.0" | ||
hilt = "2.56.2" | ||
hiltExt = "1.2.0" | ||
horologist = "0.7.14-beta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
androidx-wear-compose-material3 = "1.5.0-beta01" | ||
androidx-wear-compose = "1.5.0-beta01" | ||
androidx-window = "1.3.0" | ||
androidx-wear-compose = "1.5.0-beta03" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hilt = "2.56.2" | ||
hiltExt = "1.2.0" | ||
horologist = "0.6.23" | ||
horologist = "0.7.14-beta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hilt = "2.56.2" | ||
hiltExt = "1.2.0" | ||
horologist = "0.6.23" | ||
horologist = "0.7.14-beta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
androidx-tv-material = "1.0.0" | ||
androidx-wear-compose = "1.4.1" | ||
androidx-window = "1.3.0" | ||
androidx-wear-compose = "1.5.0-beta03" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed and did manual update instead in #1575 |
Updated depedencies