-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update versions #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions #1575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating dependencies across the sample projects to newer versions. It also adjusts the automated dependency update script to handle the Jetcaster project differently, aligning with its specific versioning characteristics.
Highlights
- Dependency Updates: I've updated various library versions across the sample projects (JetLagged, JetNews, Jetchat, Jetsnack, Reply, and Jetcaster) in their respective
libs.versions.toml
files. This includes updates to Compose BOM, Material3, Lifecycle, Kotlin, KSP, Roborazzi, Spotless, Window, Wear Compose (in Jetcaster), and Media3 (in Jetcaster). - Gradle Wrapper Update: The Gradle wrapper version for the Jetcaster project has been updated from 8.13 to 8.14.2.
- Automated Update Script Modification: The
updateDeps.sh
script has been modified to exclude Jetcaster from the automated version catalog updates, as noted in the PR description due to its versioning scheme.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various dependency versions across multiple modules (JetLagged, JetNews, Jetcaster, Jetchat, Jetsnack, Reply) and refactors the scripts/updateDeps.sh
script. The script modification changes the strategy for updating version catalogs: Jetcaster is now excluded from automated updates, and other specified modules have their version catalogs updated individually. The version bumps appear to be mostly routine maintenance.
My review focuses primarily on the scripts/updateDeps.sh
changes:
- Documentation Mismatch: The script's new logic for updating dependencies means that existing comments within the script itself, and importantly, the header comments in all
libs.versions.toml
files, no longer accurately describe the update process. This can lead to confusion for future maintenance and should be addressed. - Minor Formatting: A missing newline at the end of the
scripts/updateDeps.sh
file.
The version changes in the libs.versions.toml
files, including Jetcaster's specific deviations, seem consistent with the PR's intent.
…now (as it doesn't follow stable versioning anymore)
9a504a4
to
1cfbf77
Compare
And update dependency script to ignore Jetcaster for now (as it doesn't follow stable versioning anymore)