-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetSearchContentsCountUseCase should not exist #1283
Comments
…hViewModel - Remove GetSearchContentsCountUseCase. - Remove GetSearchContentsCountUseCase from SearchViewModel. - Remove GetSearchContentsCountUseCase from SearchViewModelTest. Fixes android#1283
I wonder why we should remove that use case rather than migrate the business logic from repository? When we decide to use optional domain layer, move the repository's business logic to domain layer. It makes sense to me. I read this documentation. The reason of deleting use case is that so complicated to apply domain?
And In this 'Now in Android', is this GetSearchContentsCountUseCase, and getSearchContentsCount in DefaultSearchContentRepository business logic complex to use in domain? |
Following the same reasoning, what do you think about eliminating |
Callers should call the repository interface directly.
https://github.com/android/nowinandroid/blob/main/core/domain/src/main/kotlin/com/google/samples/apps/nowinandroid/core/domain/GetSearchContentsCountUseCase.kt
The text was updated successfully, but these errors were encountered: