Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly call SearchContentsRepository interface in SearchViewModel #1284

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

sanao1006
Copy link
Contributor

@sanao1006 sanao1006 commented Mar 15, 2024

What I have done and why
from this discussion

  • Remove GetSearchContentsCountUseCase.
  • Remove GetSearchContentsCountUseCase from SearchViewModel.
  • Remove GetSearchContentsCountUseCase from SearchViewModelTest.

Fixes #1283

note

when the formatting by spotless was done, the code was modified in a part of the code that has practically nothing to do with this PR (collectJob part).

…hViewModel

- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.

Fixes android#1283
@sanao1006 sanao1006 marked this pull request as ready for review March 15, 2024 00:31
@dturner dturner merged commit 88c3eb0 into android:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetSearchContentsCountUseCase should not exist
2 participants