Should skip SEI payload when SEI type mismatch

[pengbins]

This PR tries to fix #2456

The function parseH265Sei3dRefDisplayInfo tries to find SEI of type 179 and extract 3d ref DisplayInfo from it. But when the SEI type does not match 179, it fails to properly skip the unprocessed SEI payload. Instead, it continues searching for the number 179 within the payload content. This may mistakenly treat payloads of other types SEI as the target type (179), leading to incorrect parsing and eventual through an exception.

The missing else branch is added to skip payload bytes.

[icbaker]

Thanks for the fix!

Some questions:

• Can we use sample_with_sei_.mp4 to add a test for this (I'll do this in a follow-up after merging this PR)?
• Did you craft it from an existing MP4 sample asset?
  • Do you have an easy command for this?
  • And which sample file did you start with (so I can mark it as correctly branched in our VCS)?

[icbaker]

Oh can you also re-target this PR agains the main branch please?

[icbaker]

Oh can you also re-target this PR agains the main branch please?

Alternatively I'm happy to make the change directly internally and send it for review, if you're happy to get the fix but without merging this PR - let me know :)

[pengbins]

Oh can you also re-target this PR agains the main branch please?

done

[pengbins]

Thanks for the fix!

Some questions:

• Can we use sample_with_sei_.mp4 to add a test for this (I'll do this in a follow-up after merging this PR)?

Yes, it's OK.

• Did you craft it from an existing MP4 sample asset?

  • Do you have an easy command for this?
  • And which sample file did you start with (so I can mark it as correctly branched in our VCS)?

I transcoded it from sample_twos_pcm.mp4 using our own HEVC encoder. Some custom data was added to SEI by our encoder.

[icbaker]

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!