Skip to content

Should skip SEI payload when SEI type mismatch #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 2 commits into from
May 23, 2025
Merged

Should skip SEI payload when SEI type mismatch #2457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33879e9
Should skip SEI payload when SEI type mismatch
pengbins May 22, 2025
eb35980
Add release note
icbaker May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASENOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
placeholder seek points), and fall back to binary search seeking if the
duration of the file is known
([#2327]()https://github.com/androidx/media/issues/2327).
* Fix parsing of H.265 SEI units to fully skip unrecognized SEI types
([#2456]()https://github.com/androidx/media/issues/2456).
* DataSource:
* Audio:
* Add support for all linear PCM sample formats in
Expand Down
2 changes: 2 additions & 0 deletions libraries/container/src/main/java/androidx/media3/container/NalUnitUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1868,6 +1868,8 @@ public static H265Sei3dRefDisplayInfoData parseH265Sei3dRefDisplayInfo(
mantissaRefDisplayWidth,
exponentRefViewingDist,
mantissaRefViewingDist);
} else {
data.skipBits(payloadSize * 8);
}
}
return null;
Expand Down