A2 hash should use the request's method (closes #13) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC2617 3.2.2.3 A2, 'If the "qop" directive's value is "auth" or is unspecified, then A2 is': A2 = Method ":" digest-uri-value Before this commit 'Method' was always GET even if the request was a POST, PUT, etc. For some reason, this bug has only posed a problem for SetReview. In other cases Gerrit seems to accept the request rather than returning 401 Unauthorized.
1 similar comment
|
@andygrunwald PTAL. Also, thanks @timou for the second set of eyes when debugging this! |
| @@ -51,7 +51,7 @@ func (s *AuthenticationService) SetDigestAuth(username, password string) { | |||
| // returns 401 Unauthorized and authType was set to authTypeDigest. The | |||
| // resulting string is used to set the Authorization header before retrying | |||
| // the request. | |||
| func (s *AuthenticationService) digestAuthHeader(response *http.Response) (string, error) { | |||
| func (s *AuthenticationService) digestAuthHeader(method string, response *http.Response) (string, error) { | |||
There was a problem hiding this comment.
The response object contains the original request.
So you dont have to pass themethodhere. I thinkresponse.Request.Method` should work here.
See https://golang.org/pkg/net/http/#Response
What do you think?
There was a problem hiding this comment.
Agreed and good point. We're already using response.Request elsewhere in that same function too...not sure why I missed it.
|
Thank you for debugging this. I made one small commit and like to get your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC2617 3.2.2.3 A2, 'If the "qop" directive's
value is "auth" or is unspecified, then A2 is':
Before this commit 'Method' was always GET even if
the request was a POST, PUT, etc.
For some reason, this bug has only posed a problem
for SetReview. In other cases Gerrit seems to accept
the request rather than returning 401 Unauthorized.