Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A2 hash should use the request's method (closes #13) #14

Merged
merged 2 commits into from
Sep 19, 2016
Merged

A2 hash should use the request's method (closes #13) #14

merged 2 commits into from
Sep 19, 2016

Commits on Sep 19, 2016

  1. A2 hash should use the request's method (closes #13) 

    According to RFC2617 3.2.2.3 A2, 'If the "qop" directive's
value is "auth" or is unspecified, then A2 is':

  A2       = Method ":" digest-uri-value

Before this commit 'Method' was always GET even if
the request was a POST, PUT, etc.

For some reason, this bug has only posed a problem
for SetReview.  In other cases Gerrit seems to accept
the request rather than returning 401 Unauthorized.
    @opalmer
    opalmer committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    77aabc8 View commit details
    Browse the repository at this point in the history

  2. use method from original request

    @opalmer
    opalmer committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    d595c54 View commit details
    Browse the repository at this point in the history