SetReview should return a ReviewResult #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST api for Gerrit states that: As response a ReviewResult entity is returned that describes the applied labels and any added reviewers (e.g. yourself, if you set a label but weren’t previously a reviewer on this CL). go-gerrit however was returning a ReviewInfo entity that was missing the reviewers and ready fields.
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 17.94% 17.94%
=======================================
Files 21 21
Lines 1750 1750
=======================================
Hits 314 314
Misses 1403 1403
Partials 33 33
Continue to review full report at Codecov.
|
|
@andygrunwald this one should be pretty quick. Looks like there aren't any tests to cover this...found out about it while working on gerrittest.Change. |
andygrunwald
approved these changes
Sep 11, 2017
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST api for Gerrit states that:
As response a ReviewResult entity is returned that describes the
applied labels and any added reviewers (e.g. yourself, if you set
a label but weren’t previously a reviewer on this CL).
go-gerrit however was returning a ReviewInfo entity that was missing
the reviewers and ready fields.