Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetReview should return a ReviewResult #40

Merged
merged 3 commits into from
Sep 11, 2017
Merged

SetReview should return a ReviewResult #40

merged 3 commits into from
Sep 11, 2017

Commits on Sep 10, 2017

  1. SetReview should return a ReviewResult 

    The REST api for Gerrit states that:

  As response a ReviewResult entity is returned that describes the
  applied labels and any added reviewers (e.g. yourself, if you set
  a label but weren’t previously a reviewer on this CL).

go-gerrit however was returning a ReviewInfo entity that was missing
the reviewers and ready fields.
    @opalmer
    opalmer committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    c1aab26 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @opalmer
    opalmer committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    a7aa15a View commit details
    Browse the repository at this point in the history

  3. fix update to changelog...

    @opalmer
    opalmer committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    139440f View commit details
    Browse the repository at this point in the history