Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3a Monitor run notebook does not plot until the end of run #306

Closed
HPiyadasa opened this issue Jan 4, 2023 · 3 comments · Fixed by #313
Closed

3a Monitor run notebook does not plot until the end of run #306

HPiyadasa opened this issue Jan 4, 2023 · 3 comments · Fixed by #313
Assignees
Labels
enhancement New feature or request

Comments

@HPiyadasa
Copy link

Describe the bug
Watcher script finds the bin files and extracts the tiffs and generates the MPH metrics (found in appropriate dir) but does not plot graphs until the run is finished

Expected behavior
Plots should be generated (channel stats, MPH plot etc) and updated every time a new FOV is found.

@HPiyadasa HPiyadasa added the bug Something isn't working label Jan 4, 2023
@ngreenwald ngreenwald added enhancement New feature or request and removed bug Something isn't working labels Jan 5, 2023
@HPiyadasa
Copy link
Author

In addition, when/if a run is interrupted halfway on the MIBI scope, start_watcher function will keep watching for new FOVs without generating any plots as a new run will be initiated for the remaining FOVs while the original run json file will never be completed.

@ngreenwald
Copy link
Member

Maybe adding an additional cell that the user could run in the even that their MIBI run failed, which would trigger all of the run_callbacks.

@alex-l-kong
Copy link
Contributor

In addition, when/if a run is interrupted halfway on the MIBI scope, start_watcher function will keep watching for new FOVs without generating any plots as a new run will be initiated for the remaining FOVs while the original run json file will never be completed.

We should make this a separate issue. I'll open one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants