Add ability to override run callbacks to process per FOV #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
alex-l-kong
changed the title
|
@srivarra all up and running now! The failing tests are from the old MIBItracker API code, we don't have to worry about that for this PR. |
Closed
|
@alex-l-kong and @srivarra, will you guys take a look through the whole thing to confirm you guys are both happy with the final result? |
alex-l-kong
commented
Mar 13, 2023
|
@srivarra and I reviewed, looks good on our end. |
ngreenwald
approved these changes
Mar 13, 2023
camisowers
reviewed
Mar 13, 2023
| @@ -264,14 +266,11 @@ def sort_bin_file_fovs(fovs, suffix_ignore=None): | |||
| ) | |||
|
|
|||
|
|
|||
| def compute_qc_metrics(bin_file_path, extracted_imgs_path, fov_name, | |||
| def compute_qc_metrics(extracted_imgs_path, fov_name, | |||
There was a problem hiding this comment.
Note that the generate_qc FOV callback actually calls compute_qc_metric_direct itself, not this function. I think this was leftover from when the function above used the bin files for calculation, so Adam made a "direct" function to skip that re-extraction while running watcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #311. Closes #306. Closes #311
How did you implement your changes
See design doc in #311.