Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySide6 refactor #733

Merged
merged 8 commits into from
Oct 18, 2022
Merged

PySide6 refactor #733

merged 8 commits into from
Oct 18, 2022

Conversation

twizmwazin
Copy link
Member

@twizmwazin twizmwazin commented Sep 30, 2022

Instructions to test:

  1. Set up an angr-dev environment as normal.
  2. Install the master branch of https://github.com/angr/pyqodeng to your environment.
  3. Install this branch.
  4. Enjoy!

image

@twizmwazin twizmwazin marked this pull request as draft September 30, 2022 22:33
@twizmwazin twizmwazin mentioned this pull request Sep 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Unit Test Results

5 tests  ±0   5 ✔️ ±0   17s ⏱️ -1s
5 suites ±0   0 💤 ±0 
5 files   ±0   0 ±0 

Results for commit fef365d. ± Comparison against base commit 9cb5574.

♻️ This comment has been updated with latest results.

@twizmwazin twizmwazin marked this pull request as ready for review October 3, 2022 23:31
@twizmwazin
Copy link
Member Author

So this seems like it was even less work than I was thinking. There are still issues, mostly in pyqodeng, but as far as I can tell the UI otherwise works. Would people be able to give this a go and see if they can find issues?

@ltfish
Copy link
Member

ltfish commented Oct 17, 2022

Currently fails on PySide6 6.4 because of the following issues:

@ltfish ltfish self-assigned this Oct 17, 2022
@ltfish
Copy link
Member

ltfish commented Oct 17, 2022

I'm going to merge this branch to master as soon as CI passes.

@ltfish ltfish merged commit d2096c2 into master Oct 18, 2022
@ltfish ltfish deleted the pyside6 branch October 18, 2022 00:56
@ltfish
Copy link
Member

ltfish commented Oct 19, 2022

Currently fails on PySide6 6.4 because of the following issues:

* https://bugreports.qt.io/browse/PYSIDE-2088

* [Don't re-assign Qt.MouseButton.MiddleButton on PySide6 spyder-ide/qtpy#374](https://github.com/spyder-ide/qtpy/pull/374)

Both issues have been fixed. We can move to PySide6 6.4.x once qtpy and PySide6 release new versions to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants