feat: add support for Angular v11 (follow up)

[JohannesHoppe]

In retrospective, it wasn't my best idea to introduce the --configuration param. 😅

• configuration is misleading as it might be confused with configurations. @alan-agius4 already pointed this out here: feat(ng-deploy): add option for buildTarget angular/angularfire#2063 (comment)
• meanwhile, the CLI got configurations for ng deploy commands (which is NOT meant to be the configuration for the build as we did) @george43g pointed this out here: ❌ deprecated [RFC] A deployment builder must always compile the project before the deployment ngx-deploy-starter#1 (comment)

I think we want some kind of deprecation of our --configuration param since it's colliding with the designated param. We already have a breaking change due to the new stable deploy api. So let's clean everything up now.

See also
angular/angularfire#2281

follow up of: #118

FYI @beeman @dianjuar @mgechev

[beeman]

@JohannesHoppe I think it's a good call to clean it up! Happy to jump in to help, or test it locally!

[JohannesHoppe]

Great, so let's enable the same kind of stuff like in angularfire. 🙂

I wonder what we do with people who now use ng deploy configuration=production. The correct command would then be ng deploy --buildTarget=production. But I cannot introduce an alias for a transition period because --configuration has a new meaning. Do you think it is sufficient to write the following text in red letters?

WARNING: The configuration option for specifying the BUILD has been renamed to buildTarget. Please change the parameter (eg. rename ng deploy --configuration=production to ng deploy --buildTarget=production). If you really want to adjust the DEPLOYMENT configuration, you can ignore this message.

Or do you have a better idea?

[beeman]

@JohannesHoppe I think that's a great solution to move away from the existing variable. Especially when you release it under a new major version folks can expect a breaking change :)

[dianjuar]

@beeman I couldn't agree more.

• Release those changes under a new major version
• The warning that you mention on the changelog

I think that should be enough.

[dianjuar]

@JohannesHoppe I think I should do the same on ngx-deploy-npm, following up all your comments and links sounds the way to go.

[JohannesHoppe]

🎉

Gentleman, I have pushed v1.0.0-rc.1 to NPM. Can you please give it a try and give me feedback if everything is fine?

I already left the tag to latest, so that it doesn't break for all people anymore.

[beeman]

Thanks a lot for publishing the RC @JohannesHoppe! I just did a test and it seems to work like a charm!

[JohannesHoppe]

@beeman Thanks for the fast feedback. I will merge this PR to have the README up to date. I have some more ideas for rc2, so I would be happy for your continued support. 👍

[beeman]

@beeman Thanks for the fast feedback. I will merge this PR to have the README up to date. I have some more ideas for rc2, so I would be happy for your continued support. 👍

For sure! I'm using it in several projects I'm currently working on so feel free to ping me when there is something to test 👍

[inpercima]

I just did a test too and it works. Thanks a lot. 👍

But I do got some warnings on installing with yarn.

warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/architect@>= 0.900 < 0.1200".
warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/core@^9.0.0 || ^10.0.0 || ^11.0.0".
warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/schematics@^9.0.0 || ^10.0.0 || ^11.0.0".

Not sure why. The dependencies are installed.

[JohannesHoppe]

🤔

[beeman]

I'm seeing the same. Here's a repro:

$ git clone git@github.com:beeman/angular-cli-ghpages-test.git
$ cd angular-cli-ghpages-test
$ yarn
yarn install v1.22.10
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/architect@>= 0.900 < 0.1200".
warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/core@^9.0.0 || ^10.0.0 || ^11.0.0".
warning " > angular-cli-ghpages@1.0.0-rc.1" has unmet peer dependency "@angular-devkit/schematics@^9.0.0 || ^10.0.0 || ^11.0.0".
[4/4] 🔨  Building fresh packages...
✨  Done in 65.31s.