fix(options): add labelling options for a11y #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the option to label slider(s) for screen readers using either a direct label via `aria-label` or as a reference using `aria-labelledby`. fixes issue #492
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 934 942 +8
=====================================
+ Hits 934 942 +8
Continue to review full report at Codecov.
|
|
Thanks for this pull request, it looks very clean (it even has tests 😄 )! 👍 . I'll look into it more deeply tonight, merge it and release a new NPM version for it. |
|
Release under 6.1.0. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the option to label slider(s) for screen readers using either a direct label via
aria-labelor as a reference usingaria-labelledby.fixes issue #492
http://jsfiddle.net/ov8r2r89/