Support for Angular 1.2

[francisdb]

Just wanted to put this on the agenda by creating a ticket.
http://docs.angularjs.org/guide/migration

[nlaplante]

Hi, thanks for reporting. Did you run in any issue with 1.2?

[francisdb]

Haven't tried yet, it's in my backlog somewhere ;-)

[nlaplante]

Just added this to our Trello board https://trello.com/c/3tJSkJhJ/10-specs-for-api-would-like-at-least-75-coverage-b4-release

[nmccready]

Sounds like a good idea 👍 This 'should' be easy.

[Splaktar]

I just tried with AngularJS 1.2.0 (current stable release) and I found the following issues that I haven't seen posted elsewhere here. This is using the r1-dev branch.

Error: [$compile:multidir] Multiple directives [googleMap, markers] asking for new/isolated scope on:
http://errors.angularjs.org/1.2.0/$compile/multidir?p0=googleMap&p1=markers&p2=new%2Fisolated%20scope&p3=%3Cgoogle-map%20center%3D%22center%22%20draggable%3D%22true%22%20zoom%3D%22zoom%22%20markers%3D%22markers%22%20style%3D%22height%3A%20400px%22%3E
at http://localhost:8888/lib/angular.js:78:12
at assertNoDuplicate (http://localhost:8888/lib/angular.js:6291:15)
at applyDirectivesToNode (http://localhost:8888/lib/angular.js:5738:13)
at compileNodes (http://localhost:8888/lib/angular.js:5463:15)
at compile (http://localhost:8888/lib/angular.js:5402:15)
at http://localhost:8888/lib/angular-route.js:850:26
at publicLinkFn (http://localhost:8888/lib/angular.js:5420:29)
at <error: illegal access>
at Scope.$broadcast (http://localhost:8888/lib/angular.js:11803:28)
at http://localhost:8888/lib/angular-route.js:549:26

So I removed the markers="markers" and saw the following:

Error: [$injector:unpr] Unknown provider: google-mapsProvider <- google-maps
http://errors.angularjs.org/1.2.0/$injector/unpr?p0=google-mapsProvider%20%3C-%20google-maps
at http://localhost:8888/lib/angular.js:78:12
at http://localhost:8888/lib/angular.js:3444:19
at Object.getService as get
at http://localhost:8888/lib/angular.js:3449:45
at getService (http://localhost:8888/lib/angular.js:3571:39)
at invoke (http://localhost:8888/lib/angular.js:3593:13)
at Object.instantiate (http://localhost:8888/lib/angular.js:3629:23)
at http://localhost:8888/lib/angular.js:6581:28
at http://localhost:8888/lib/angular-route.js:858:34
at publicLinkFn (http://localhost:8888/lib/angular.js:5420:29)

[nmccready]

cool ty

[armno]

+1 for this.

my map stopped showing info window after upgraded to angular 1.2
it was working when i used angular 1.2rc3.
here are my logs

TypeError: Object function (){return b.data("instance")} has no method 'getMarker'
    at http://localhost:8000/app/lib/angular-google-maps/angular-google-maps.min.js:6:8077
    at http://localhost:8000/app/lib/angular/angular.js:13152:28
    at completeOutstandingRequest (http://localhost:8000/app/lib/angular/angular.js:3996:10)
    at http://localhost:8000/app/lib/angular/angular.js:4302:7

thanks 👍

[nlaplante]

r1-dev?

[armno]

yes i'm using r1-dev branch.

On Friday, November 15, 2013, Nicolas Laplante wrote:

r1-dev?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-28563772
.

ArmNo
http://armno.in.th

[nmccready]

Starting on this

[nmccready]

I am almost done this but I am running into issues with this problem.
angular/angular.js#4935

Trying to resolve it like this example.
http://plnkr.co/edit/oeWTQbzrBGSBzi1iu2WQ?p=preview

Example, https://github.com/nlaplante/angular-google-maps/blob/ng1.2.2/src/js/directives/map.js

[nmccready]

Actually the portion of that plunker is incorrect to use. Working on it.

[nmccready]

@francisdb @armno @nlaplante I just completed the upgrade for this. The only warning on it is a error in angular.js itself for Jquery event.returnValue where it should use event.preventDefault. This may mean that I need to update the jquery version in our example. I will submit a PR as this will not be merged until someone confirms it works with their environment. I will test it later. But getting this done is urgent as I want to get r1-dev to master today.

[nmccready]

#148