Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

NG - 1.2.2 support #148

Merged
merged 3 commits into from
Nov 27, 2013
Merged

NG - 1.2.2 support #148

merged 3 commits into from
Nov 27, 2013

Conversation

nmccready
Copy link
Contributor

@francisdb @armno @nlaplante I just completed the upgrade for this. The only warning on it is a error in angular.js itself for Jquery event.returnValue where it should use event.preventDefault. This may mean that I need to update the jquery version in our example. I will submit a PR as this will not be merged until someone confirms it works with their environment. I will test it later. But getting this done is urgent as I want to get r1-dev to master today.

@ghost ghost assigned nlaplante Nov 27, 2013
@nlaplante
Copy link
Contributor

Looks fine. I get the warning on another non-AngularJS project at work too so I think it's no biggie. Waiting for Travis build to end to merge this,

nlaplante added a commit that referenced this pull request Nov 27, 2013
@nlaplante nlaplante merged commit 16b8926 into r1-dev Nov 27, 2013
@nmccready nmccready deleted the ng1.2.2 branch November 27, 2013 15:49
@nlaplante
Copy link
Contributor

Nice job @nmccready . I'm sad these days I cannot work at all on this. FT job + evening time contract takes all my time...

@nmccready
Copy link
Contributor Author

Thanks, Yeah I here yah I barley have time either. Thank god for holiday
vacay.

Nicholas McCready

Personal Email: nmccready@gmail.com
Web site: http://codemonkeyseedo.blogspot.com/
Twitter: nmccready https://twitter.com/#!/nmccready

On Wed, Nov 27, 2013 at 11:02 AM, Nicolas Laplante <notifications@github.com

wrote:

Nice job @nmccready https://github.com/nmccready . I'm sad these days I
cannot work at all on this. FT job + evening time contract takes all my
time...


Reply to this email directly or view it on GitHubhttps://github.com//pull/148#issuecomment-29395837
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants