This repository was archived by the owner on Nov 30, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@francisdb @armno @nlaplante I just completed the upgrade for this. The only warning on it is a error in angular.js itself for Jquery event.returnValue where it should use event.preventDefault. This may mean that I need to update the jquery version in our example. I will submit a PR as this will not be merged until someone confirms it works with their environment. I will test it later. But getting this done is urgent as I want to get r1-dev to master today.