Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Fixes for some memory leaks but i'm unable to implement them correctly. #1531

Closed
@spyridonas

Description

@spyridonas

I don't know how to correctly implement them , since i don't know how coffeescipt works, maybe someone more experienced can help out. The problem i had was that when i refreshed the markers from ui-gmap-markers the watchers count was growing and growing. A fix was provided by @nmccready on #1524 (pr #1528) but not everything was fixed. After looking around at the code i noticed on window-child-model.coffee (src\coffee\directives\api\models\child) there where more commands on the "remove" than on the "destroy" . After copying the commands from remove to copy one of my issues where fixed ( the problem is i don't know exactly what fixed it). Then on src\coffee\directives\api\managers\marker-manager.coffee i copied over the same commands to the "destroy" and "clear" and more issues where fixed with this. Can somebody implement this fix properly and pr it ? Also i think that all of remove/destroy functions should be looked at, that two affect my implementation of angular-google-maps. Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions