This repository was archived by the owner on Nov 30, 2018. It is now read-only.
issue 1524 Window Scope Leaks #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WindowsParent model now correctly destroys its child model's scopes. - coffeelint fixes - templates in child windows will destroy when its window scope destroys issue angular-ui#1524
| @@ -47,6 +47,7 @@ angular.module('uiGmapgoogle-maps.directives.api.models.child') | |||
| else | |||
| action = new PropertyAction (calledKey, newVal) => | |||
There was a problem hiding this comment.
small bug here where clicked marker was not updating as there was no key, forcing the key all allows updated to propagate through.
|
I tested the crap out of this against the example.js/html but it would be nice to add specs for looking for leaks eventually. Maybe someone else can work this? |
|
@cthrax @wrummler |
nmccready
added a commit
that referenced
this pull request
Sep 23, 2015
…ow_leaks issue 1524 Window Scope Leaks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(window memory scope leaks): - WindowsParent model now correctly destroys its child model's scopes. - coffeelint fixes - templates in child windows will destroy when its window scope destroys
issue #1524