-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Tooltip bug with angular 1.3 #2828
Comments
@ozdavid3 we will need a minimal reproduction scenario to make this one actionable: |
I saw this too. Its actually happens when you include the ngAnimate in angular 1.3: http://plnkr.co/edit/fqqEH3bJcvwTtlnIKyxl Oddly doesn't effect popovers |
This is a minimal reproduction scenario of this bug: http://plnkr.co/edit/bYD4roQL9q1CvsuL6dk4?p=preview |
I also noticed this, and quick fix is to remove the |
In addition, setting |
Thanks for the workaround suggestion @jgrund! The project is way beyond disabling ngAnimate so this is a welcome fix. |
@jgrund thanks, better fix than disabling |
// ui-bootstrap tooltip animation is broken using angular 1.3
app.config(['$tooltipProvider', function($tooltipProvider) {
$tooltipProvider.options({animation: false});
}]); is a temporary workaround, thanks to @imjusd |
Seems the bug has already been fixed with issue #2825 |
@t4gedieb that change did work on my project. Though the tooltip takes longer to fade out once the mouse leaves than my previous build with Angular 1.2.6. |
The animation fix works just for angular 1.3.0, but not anymore for angular 1.3.1 |
@patrickstubner the animation fix isn't required while using angular 1.3.0, and the tooltip doesn't work at all in 1.3.1. |
@yonatang use ngAnimate in your app and you will need the in angular 1.3.0. |
I've looked into the issue for AngularJS 1.3.1. It'll be resolved when I merge #1817. |
This seemed to already be resolved on master: http://plnkr.co/edit/bQaZ4z5BFwfAZSzRa2Hq?p=preview |
Nice, hope that the next tag will be up soon, 0.11.3? |
+1 for 0.11.3 and fixes for tooltips |
+1 for 0.11.3 |
👍 |
+1 ☕ |
+1 |
One workaround for this before the next release happens is manually setting the tooltip trigger and placment: <div tooltip="foo bar" tooltip-trigger tooltip-placement="top"></div> Or you can make a temporary directive hack to add in the attributes: app.directive('tooltip', function() {
return {
restrict: 'EA',
link: function(scope, element, attrs) {
attrs.tooltipTrigger = attrs.tooltipTrigger;
attrs.tooltipPlacement = attrs.tooltipPlacement || 'top';
}
}
}); |
Setting the tooltip trigger and placement worked! Thank you @clarkduvall |
This has been resolved on master. Thanks for reporting! |
Did it make it to 0.12.0 release? |
It appears so. Tooltips animate fine in my testing. If you set animation to false they're a little janky; they appear to the right briefly and then jump to wherever you set the position. I'm not sure if they behaved like that before. |
See: angular-ui/bootstrap#2828 Alternatives to upgrading were: - Add hack tooltip directive that adds the trigger/placement attrs to each tooltip - Manually add trigger/placement attrs to each tooltip in the src Update had breaking change where dropdowns require the dropdown and dropdown-toggle attributes, not just the classes. Should have been this way anyway, so the attributes were added to each dropdown.
There seems to be a problem with placement/position of tooltips, and popovers. It has something to do with the changes to angular.isDefined which works differently in AngularJS 1.2 & 1.3 Here are a few directives to patch the issues by setting defaults
|
@cnaccio Wow thanks for that. Also; It fixed my issue on 0.11; I switched later on 0.12.1 and it was fixed 👍 |
I'm still seeing the "jumping" problem (tooltip appears too far to the right and then immediately 'jumps') on angular bootstrap 0.13.3/Angular 1.3.10 (also saw it in 1.4.3). Animation is false and I've set tooltip-trigger and tooltip-placement on the elements in question. |
When migrating to angular 1.3 tooltip stops showing.
It seems like the element does show on the DOM but its class attribute does not contain required classes in order to change opacity (so opacity stays 0).
The text was updated successfully, but these errors were encountered: