-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(tooltip): Use only once, don't use an empty transclusion fn #2825
Conversation
Thnx @Igosuki ! |
@Igosuki , could you post a Plunker demonstrating this breakage? I don't see it and now this change actually causes symptoms demonstrated in #2935 . This change is actually incorrect as it never binds the template to a new scope after the first time it's linked, since no new clones are created. I've checked the documentation and I don't see this breakage that you mention. |
I'll be reverting this change on master. If you have a test case for this change, please do post it so I can look into it. |
Will do ! Just have to extract the test case from my app. |
Thanks to @red-0ne for the test case. This commit reverts a1b1ec4 (angular-ui#2825) . Fixes angular-ui#2935
Hey @chrisirhc sorry I didn't get back to you on this. #2951 does demonstrate the exact problem. And I don't see any issues upgrading to 0.12 with your merges. |
Thanks for the find, I am closing this PR as it appears this is no longer an issue with the changes that have been made to the tooltip. |
The additional $digest and empty transclusion seem unnecessary in 1.2 and are breaking changes in 1.3 (ng-class breaks).