Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Update tabs.js #1335

Closed
wants to merge 1 commit into from
Closed

Update tabs.js #1335

wants to merge 1 commit into from

Conversation

zsong
Copy link

@zsong zsong commented Dec 2, 2013

Fixed the issue of "Cannot read property '$parent' of undefined" error when use the tabset directive inside the accordion directive. Tested with AngularJS 1.2.2.

Fixed the issue of "Cannot read property '$parent' of undefined" error when use the tabset directive inside the accordion directive. Tested with AngularJS 1.2.2.
@vinteo
Copy link

vinteo commented Dec 5, 2013

this also happens when you have a tabset within a tab of a parent tabset

@Coridyn
Copy link
Contributor

Coridyn commented Dec 16, 2013

Thanks, your change sorts it out for me.
I've encountered this issue when the tabset is inside ng-if:

<div ng-cloak ng-if="isReady">
    <div class="main-panel">
        <div tabset type="'pills'">
            <div tab>
                <div tab-heading>Heading 1</div>
                <div>...content...</div>
            </div>

            <div tab>
                <div tab-heading>Heading 2</div>
                <div>...content...</div>
            </div>
        </div>
    </div>
</div>

@chrisirhc
Copy link
Contributor

Note to self to check again after #1362 gets merged (if it does get merged).

@chrisirhc
Copy link
Contributor

@zsong , could you check if this is still an issue on master since #1362 has been merged?

@pkozlowski-opensource
Copy link
Member

@zsong @chrisirhc I think this definitively can be closed now. @zsong feel free to open another issue if you still face problems with the latest code from master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants