fix(tabs): Make nested tabs work #1362
Conversation
|
Sorry to bring this up here, but from my understanding the problem was introduced when orientation option was added. Since BS3 has dropped this functionality, is it probably better for us to just revert 220e7b6 and save ourselves from all these problems, since we will not be able to support two different code bases for bs2 and bs3? |
|
I wasn't aware that it was dropped. I guess reverting that change and dropping the option is a good idea too. @pkozlowski-opensource mentioned that there could still be a maintenance branch for 0.7.0 for those sticking to BS2. |
|
Oh yes, if we decide that this option should be dropped, I still suggest that these tests should be added. I can rename the pull request to "chore(tabs): Add tests for nested tabs". |
|
+1 for dropping support for directions and adding tests for nested tabs. I've got tests ready somewhere, need to dig them out... |
|
I have included some tests in this pull request. I can reformat this request to contain only tests. |
|
Agree that these tests are valuable. |
This reverts commit 220e7b6. Revert the capability to set the tab direction. This is no longer a feature in Bootstrap 3 and breaks nested tabs. Closes angular-ui#783 Relates to angular-ui#659
|
@pkozlowski-opensource this is ready for review/merge. |
|
@chrisirhc LGTM |
|
@chrisirhc Awesome stuff! Your commits just landed in master. Thnx for the great work. |
Add tests for nested tabs. Revert ability to set direction of tabs.
Reverts #659 and Closes #783