feat(dropdown): support programatic trigger, toggle callback & esc key

[bekos]

No description provided.

[bekos]

@angular-ui/bootstrap Anyone willing for a code review?

This is basically a refactor, but I tried not to introduce any breaking change. The idea is to make the dropdown element as the main directive, and dropdownToggle is just an optional directive that hooks in dropdown's controller to change it's state.

[chrisirhc]

Took a quick look. Will read in more detail later tonight. How about using the element's blur event instead? And perhaps triggering blur on escape?

[Foxandxss]

Don't we have the need to test that isopen is false when the event is triggered?

[bekos]

This line is removed. This test is moved at line 67.

[Foxandxss]

👍 for me. Extra stuff that is useful, non-breaking and with no overhead. Why not? :)

[bekos]

@chrisirhc This seems reasonable, I need to investigate though :-)

[bekos]

@chrisirhc Checked with bootstrap and they also use document click to hide the menu. This way you can navigate on the page with tab without closing the dropdown. Is there any specific issue you see that we should not use document click?

[chrisirhc]

Possibly rename this to closeDropdown.

[bekos]

Yeah, probably I should extract the

openScope.$apply(function() {
      openScope.isOpen = false;
    });

into a closeDropdown function and call from the bindings.

[chrisirhc]

Ah you're right, somehow I had the impression that tab should dismiss the dropdown toggle, but I was wrong.

[chrisirhc]

This should take in an argument open and check if arguments are 0:

if (arguments.length) {
  return $scope.isOpen = !!open;
} else {
 return $scope.isOpen = !$scope.isOpen;
}

This way it can handle an argument that sets the open explicitly and it also returns the actual value after the toggle.

[bekos]

Yes, that's nice, but there was no use case for this. See test coverage report :-D
Do you want to add as future proof solution in case someone wants to hook on the controller, right?

[ajoslin]

@bekos I like @chrisirhc's idea. Use-case: Perhaps there's a tutorial where it says "When you click here, this dropdown will open!".

and you want to make sure it actually stays open and doesn't close if the user already had it open.

[bekos]

@ajoslin The toggle method is not exposed to the directive. It is only used by the dropdown toggler to do the toggling.
I have added in the demo a button that does what you say, by just setting the is-open to true.
I think @chrisirhc is wanting this in case another directive wants to use it.

[bekos]

I will make the change anyway :-)

[bekos]

Thanks for the review! I will change the issues mentioned and merge it. I would also rename the module from dropdownToggle to dropdown as this is now the main directive, if of course there are no objections.

[bekos]

Landed on master.