refactor(dropdownToggle): listen to $locationChangeSuccess

[bekos]

No description provided.

[pkozlowski-opensource]

Ha! One $watch less, good!

[lanterndev]

Extra psyched about this landing due to angular/angular.js#4608. Thanks, @bekos!

I wonder if it might even fix #619?

Also, I notice $location is still getting injected in the test for this:
https://github.com/angular-ui/bootstrap/blob/master/src/dropdownToggle/test/dropdownToggle.spec.js#L6
Not sure if it's hurting anything but looks like it's not necessary anymore.

[bekos]

@Skivvies I was also having a problem when injecting $location caused IE8 to refresh the page without any apparent reason. Also, when working on #1616 just injecting it in the tests maked them fail!!!

About the #619 I don't think it's fixed yet, but you are free to test with the latest master.

[lanterndev]

@bekos wrote:

@Skivvies I was also having a problem when injecting $location caused IE8 to refresh the page without any apparent reason. Also, when working on #1616 just injecting it in the tests maked them fail!!!

Sounds like $location causes problems / unexpected behavior in lots of places. Would be great if you mentioned any relevant experience or suggestions you have in angular/angular.js#4608 if you get a chance. And thanks again for this PR!

[jgrund]

Am I missing something or was:

scope.$watch('$location.path', function() { closeMenu(); });

not actually watching anything?

How was $location.path being set as a scope property?

[Foxandxss]

@jgrund Yeah, just noticed that too.