Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(alert): add alert-dismissable class #1745

Closed
wants to merge 1 commit into from

Conversation

bekos
Copy link
Contributor

@bekos bekos commented Feb 5, 2014

No description provided.

@bekos bekos closed this in 794954a Feb 7, 2014
@bcronje
Copy link

bcronje commented Mar 17, 2014

It's worth noting that this commit breaks the demo page. You need to change type="alert.type" to type="{{alert.type}}" to get it working again.

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this pull request May 5, 2014
Regression from angular-ui#1745 as there's a double interpolation expected but
ngClass doesn't support that.

The attribute value of ngClass is only interpolated once and the
interpolated expression is watched.

Fixes angular-ui#2145
chrisirhc added a commit that referenced this pull request May 5, 2014
Regression from #1745 as there's a double interpolation expected but
ngClass doesn't support that.

The attribute value of ngClass is only interpolated once and the
interpolated expression is watched.

Fixes #2145
Closes #2146
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants