This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(alert): correct binding of alert type class #2146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from angular-ui#1745 as there's a double interpolation expected but ngClass doesn't support that. The attribute value of ngClass is only interpolated once and the interpolated expression is watched. Fixes angular-ui#2145
| @@ -1,4 +1,4 @@ | |||
| <div class="alert" ng-class="{'alert-{{type || 'warning'}}': true, 'alert-dismissable': closeable}" role="alert"> | |||
| <div class="alert" ng-class="'alert-' + (type || 'warning') + (closeable ? ' alert-dismissable' : '')" role="alert"> | |||
There was a problem hiding this comment.
@chrisirhc It would be more readable to use the array syntax, like this:
ng-class="['alert-' + (type || 'warning'), closeable ? 'alert-dismissable' : null]"
There was a problem hiding this comment.
agreed, provided that it works :-)
|
Changed it as suggested by @bekos and landed, thnx @chrisirhc ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #1745 as there's a double interpolation expected but
ngClass doesn't support that.
The attribute value of ngClass is only interpolated once and the
interpolated expression is watched.
Fixes #2145