feat(tooltip,popover): logic moved to $tooltip svc #210
Conversation
Popover and tooltip directive creation is now performed through the help of the `$tooltip` service that manages all aspects of directive creation and management based on only the name of the component and their default triggers. The tooltip and popover sub-directives and their templates were refactored to use common scope variables that the new service can provide, yielding even greater flexibility. Animation is now enabled by default. Lastly, the `$tooltipProvider` has been established to allow setting default global options for the tooltip and popover, but these features are not yet public as the API is sure to change drastically as we flesh out which global options to allow. But the framework is in place as this was a logical time to incorporate it.
|
@joshdmiller yupppii, after modal refactoring landed and we can get this one in we will have pretty clean codebase and very good starting point for adding new features! Before merging this one we need to merge #211 since now the Jenkins-CI build is failing. |
|
Tests are passing on all browsers: http://ci.angularjs.org/job/angularui-bootstrap/258/console 👍 |
|
Looks awesome! :) |
|
Cool cool cool. Are there any objections to merging this? We keep getting duplicate bug reports that we can't solve until this is merged. Anyone want to take a final look? |
|
Go for it! It looks great 😄 |
|
@joshdmiller, yep, go for it and merge it! In fact I've already pulled your changes to the repo in this branch: https://github.com/angular-ui/bootstrap/tree/pr210_merge As you've probably noticed we are not merging through GitHub (to avoid merge commits and keep the linear history, same approach as AngularJS) but rather merging branches (if it is fast-forward) or cherry-picking changes. In short the idea is to keep one commit per logical change and a linear history. I might be merging some other PRs later today (like in 3h or so). |
|
Landed as e22f28b |
Popover and tooltip directive creation is now performed through the help
of the
$tooltipservice that manages all aspects of directivecreation and management based on only the name of the component and
their default triggers.
The tooltip and popover sub-directives and their templates were
refactored to use common scope variables that the new service can
provide, yielding even greater flexibility.
Animation is now enabled by default.
Lastly, the
$tooltipProviderhas been established to allow settingdefault global options for the tooltip and popover, but these features
are not yet public as the API is sure to change drastically as we flesh
out which global options to allow. But the framework is in place as this
was a logical time to incorporate it.