Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

chore(build): switch build to grunt 0.4 #211

Closed
wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

This is first-shot attempt at switching our build to Grunt 0.4.x. It doesn't attempt to refactor / simplify the build (which we probably could do with using grunt plugins for testacular, html2js etc. instead of providing our own implementation).

The immediate goal for me was to have a working build on the Jenkins-CI server which is broken atm, see: See #207

@pkozlowski-opensource
Copy link
Member Author

@angular-ui/bootstrap would be superb if someone could have a look and scream if there are bad parts in there. I would like to merge this PR asap as currently our build is broken on the Jenkins-CI and Igor did necessary changes already to have some of the npm modules installed locally.

@ajoslin
Copy link
Contributor

ajoslin commented Mar 12, 2013

I can check it out tonight.

@joshdmiller
Copy link
Contributor

I will also take a look this evening.

@petebacondarwin
Copy link
Member

Didn't try to run it but looks generally ok to me.

@ajoslin
Copy link
Contributor

ajoslin commented Mar 13, 2013

I didn't end up having access to my dev computer so I can't run it. But it LGTM too.

I can check it tomorrow or thursday if it's still not merged

@pkozlowski-opensource
Copy link
Member Author

Good catch @gmp26 !

I'm going to change the commit with this finding and merge it to unblock the build.

@pkozlowski-opensource
Copy link
Member Author

Landed as 98b5f8e and the CI build is green :-)
We are on the Grunt 0.4 and chacked-in markdown npm module went away :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants