This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(carousel): #488 Carousel fails to update model changes. #2953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kkruit
commented
Nov 11, 2014
kkruit
commented
- Uses dom element index instead of internal slides index.
- Adds order to indicators to match slide order.
- Uses dom element index. - Adds order to indicators to match slide order.
|
@chrisirhc, Now I remember why I was holding off on this ... #2699 Doesn't look like there should be too many conflicts. Let me know if you want a PR on that branch or something. |
| } else { | ||
| prevSlide = getLastSlide(); | ||
| } | ||
| return self.select(prevSlide, 'next'); |
There was a problem hiding this comment.
Shouldn't this be prev instead?
- Prev function calls change slide with directon of 'prev'. - Find element in slides array rather than through scope's $$childHead.
|
I'm closing this PR, as it seems the original issue is now addressed in current master - let us know if this is still a problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.