This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): incorrect position when text wraps #2996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $digest that was removed in 32c470 is actually necessary to get the tooltip contents rendered. The rendered content is important when the tooltip is on the right edge. See Plunker in angular-ui#2995: http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview Reverts change in 32c470 (angular-ui#2995) but fixes it in another way. Fixes angular-ui#2995 Fixes angular-ui#2992 Fixes angular-ui#2951 Closes angular-ui#2996
chrisirhc
force-pushed
the
feature/fix-2995
branch
from
33d7343
to
3b59062
Compare
|
Any idea when this will be merged? This patch fixes a bug where my tool tips are not positioned correctly when rolling over links on a drop down button. |
|
+1. Just spent a few hours convinced I was doing something crazy with CSS that was messing up my tooltips, turned out to be this issue that's been fixed for over a month. Would be great to see this merged. |
|
+1, this fixes tooltip positioning for me as well. Would love to see this merged sooner rather than later. |
|
+1, this also fixes the problem for me. |
|
+1 |
jasonpriem
added a commit
to ourresearch/total-impact-webapp
that referenced
this pull request
Mar 7, 2015
i think is related to this: angular-ui/bootstrap#2996
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in #2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview
Fixes #2995
Correctly fixes #2951 without removing $digest.