This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): do not close on right click #5052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wesleycho, is this technically a breaking change? Do you want to mark it as such? |
|
It should be noted that it currently behaves this way in all browsers excepting Firefox. This is a Firefox specific change. |
|
yea, i got that. i just wasn't sure if you felt it didn't explicitly need one. i guess not? :-) |
|
Can we test it? |
|
Probably - I mainly wanted to see whether it was worth testing, but seems like it is, so I will |
- Do not close the dropdown on right click when open due to Firefox's behavior
wesleycho
force-pushed
the
fix/dropdown-right-click
branch
from
0468bf2
to
2a36fe8
Compare
|
Added test |
|
LGTM. I don't follow you @thomassuckow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
behavior
Plunker in action here.
This fixes #5051