Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(dropdown): do not close on right click #5052

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dropdown/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])

if (evt && openScope.getAutoClose() === 'disabled') { return; }

if (evt && evt.which === 3) { return; }

var toggleElement = openScope.getToggleElement();
if (evt && toggleElement && toggleElement[0].contains(evt.target)) {
return;
Expand Down
9 changes: 9 additions & 0 deletions src/dropdown/test/dropdown.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@ describe('uib-dropdown', function() {
expect(element).toHaveClass(dropdownConfig.openClass);
});

it('should not close on right click', function() {
clickDropdownToggle();
element.find('ul a').trigger({
type: 'mousedown',
which: 3
});
expect(element).toHaveClass(dropdownConfig.openClass);
});

it('should close on $location change', function() {
clickDropdownToggle();
expect(element).toHaveClass(dropdownConfig.openClass);
Expand Down