Skip to content

fix(Tree View) Row expansion when Tree View and Select both enabled #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2015
Merged

fix(Tree View) Row expansion when Tree View and Select both enabled #4760

merged 1 commit into from
Nov 24, 2015

Conversation

benjamin-wilson
Copy link
Contributor

#4607
When Tree View and Select are both enabled, the Tree View expand button
did not work. The Tree View expand button was in a cell header class
who's click events are disabled. Enabling the pointer events on the
tree-header-row class resolves the issue.

When Tree View and Select are both enabled, the Tree View expand button
did not work. The Tree View expand button was in a cell header class
who's click events are disabled. Enabling the pointer events on the
tree-header-row class resolves the issue.
@benjamin-wilson benjamin-wilson changed the title Fixed Bug #4607 Tree View and Select both enabled fix(Tree View) Row expansion when Tree View and Select both enabled Nov 24, 2015
swalters added a commit that referenced this pull request Nov 24, 2015
fix(Tree View) Row expansion when Tree View and Select both enabled
@swalters swalters merged commit f715767 into angular-ui:master Nov 24, 2015
@dlgski
Copy link
Contributor

dlgski commented Dec 14, 2015

I found this fix was done in the wrong order. I found with:

                enableRowSelection: true,
                enableFullRowSelection: true,
                enableRowHeaderSelection: false,

my cell is rendered with the following div:

<div ng-repeat="(colRenderIndex, col) in colContainer.renderedColumns track by col.uid" ui-grid-one-bind-id-grid="rowRenderIndex + '-' + col.uid + '-cell'" class="ui-grid-cell ng-scope ui-grid-disable-selection ui-grid-coluiGrid-0007 ui-grid-row-header-cell" ng-class="{ 'ui-grid-row-header-cell': col.isRowHeader }" role="rowheader" ui-grid-cell="" tabindex="-1" id="1450099884304-0-uiGrid-0007-cell">

note, in CSS the order of the classes is important so the fix here did not match. You need to re-order the classes like so:

.ui-grid-tree-header-row .ui-grid-cell.ui-grid-disable-selection.ui-grid-row-header-cell {
  pointer-events: all;
}

to catch this fix

@dlgski
Copy link
Contributor

dlgski commented Dec 14, 2015

also note, this fix is to override: (in expandable.less)

 .ui-grid-cell.ui-grid-disable-selection.ui-grid-row-header-cell{
      pointer-events: none;
  }

so it makes sense to keep the order of the classes the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants