re-order styles for tree-header-row override

[dlgski]

In fix #4760 an override was introduced to allow clicking on the tree-expansion when row selection is on.

The generated code with the grid options:

enableRowSelection: true,
enableFullRowSelection: true,
enableRowHeaderSelection: false,

render each cell with the following classes:

class="ui-grid-cell ng-scope ui-grid-disable-selection ui-grid-coluiGrid-0007 ui-grid-row-header-cell"

so, the order of these classes needs to have ui-grid-cell first, followed by ui-grid-disable-selection then ui-grid-row-header-cell in order for this override to work

[AgDude]

Will you please provide a plunker (or tutorial page) demonstrating the fix. Was it simply a mistake that #4760 was merged, and it never worked, or did it work in some cases? I don't see any link in that PR or issue demonstrating that it works.

[dlgski]

I actually have no idea if it ever worked.  It took me a while on my end to find this error, I'd be curious to hear from the developer who fixed #4760 and see if there is a difference in my implementation versus theirs.
I will put together a plunker
Thanks,-Dana

On Monday, December 14, 2015 11:30 AM, Nate Dudenhoeffer <notifications@github.com> wrote:

Will you please provide a plunker (or tutorial page) demonstrating the fix. Was it simply a mistake that #4760 was merged, and it never worked, or did it work in some cases? I don't see any link in that PR or issue demonstrating that it works.—
Reply to this email directly or view it on GitHub.

[dlgski]

Here is a plunker:

http://plnkr.co/edit/oLB8m4ngQFTxdQ98vlCJ?p=preview
Click on "Refresh Rows" to populate the grid. The group by Age (or another column). Click on the + icon on a row and it will not expand.

Now try this:
http://plnkr.co/edit/rc1HzaMnF2odGptWxj39?p=preview
This plunker has my simple CSS fix.

Thanks,
-Dana

[JLLeitschuh]

Oh cool! Thanks for the plunker.

[AgDude]

Thanks for the fix, and providing the requested example.