Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

fix issue with tagging, when mouse click on options doesn't work for angular > 1.4.x #1335

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/select.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*!
* ui-select
* http://github.com/angular-ui/ui-select
* Version: 0.13.2 - 2015-10-09T15:34:24.040Z
* Version: 0.13.3 - 2015-11-30T12:23:16.040Z
* License: MIT
*/

Expand Down Expand Up @@ -519,7 +519,7 @@ uis.controller('uiSelectCtrl',
if (!item || angular.equals( ctrl.items[0], item ) ) {
return;
}
} else {
} else if(!$event){ //if not mouse click, that done to prevent setting value by activeIndex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README clearly states:

When issuing a pull request, please exclude changes from the "dist" folder to avoid merge conflicts.

// keyboard nav happened first, user selected from dropdown
item = ctrl.items[ctrl.activeIndex];
}
Expand Down
2 changes: 1 addition & 1 deletion src/uiSelectController.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ uis.controller('uiSelectCtrl',
if (!item || angular.equals( ctrl.items[0], item ) ) {
return;
}
} else {
} else if(!$event){ //if not mouse click, that done to prevent setting value by activeIndex
// keyboard nav happened first, user selected from dropdown
item = ctrl.items[ctrl.activeIndex];
}
Expand Down