fix issue with tagging, when mouse click on options doesn't work for angular > 1.4.x #1335
Conversation
for angular > 1.4.x
|
seems, that error with The Travis CI build failed not related with pull request Error: [$injector:nomod] Module 'ui.select' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. Few builds before have the same problem |
|
tests locally [15:09:49] Using gulpfile ~/projects/my-ui-select/gulpfile.js |
| @@ -519,7 +519,7 @@ uis.controller('uiSelectCtrl', | |||
| if (!item || angular.equals( ctrl.items[0], item ) ) { | |||
| return; | |||
| } | |||
| } else { | |||
| } else if(!$event){ //if not mouse click, that done to prevent setting value by activeIndex | |||
There was a problem hiding this comment.
The README clearly states:
When issuing a pull request, please exclude changes from the "dist" folder to avoid merge conflicts.
|
@vitalii Can you confirm fixed and close this? |
There is problem for tagging with ang > 1.4.x , and 1.3.x.
It's only working with tagging-label="false"
#983 (comment)
Here is descrobed workaround with tagging-label="false".
But at the same time doesn't work choosing by mouse.
In this pull request fix for it