fix(uiSelectController): Select by click on non-multiple tagging #1439
Conversation
When in tagging mode, not multiple (`taggingLabel === false`), selecting an item by click was instead calling `taggingFunc()`. This fix checks for this manual selection, whether `ctrl.search` is filled or not and acts accordingly. closes angular-ui#1357
|
Closes #1335 too |
|
Ping @aaronroberson would love to see this reviewed! |
fix(uiSelectController): select by click on non-multiple tagging When in tagging mode, not multiple (taggingLabel === false), selecting an item by click was instead calling taggingFunc(). This fix checks for this manual selection, whether ctrl.search is filled or not and acts accordingly. closes #1357
|
I merged this in 4 hours ago and it will be included in the next release. |
#1727) * When in tagging mode, not multiple (taggingLabel === false), selecting an item by click was instead calling taggingFunc(). This fix checks for this manual selection, whether ctrl.search is filled or not and acts accordingly. Same changes mad in #1439 that were mysteriously lost. Fixes #1357, #1496 and #1409 * Simplification to combine ctrl.clickTriggeredSelect in one assignment
|
In which release is this fix supposed to be included? Looking at the change set changes, I do not see the changes in the latest release at this time: 0.18.1 (2016-07-10) nor any reference to this bug in the change log. |
|
OK, I see, the fix was "re-applied" after the last release. |
|
@rorlic The updates have landed in v0.19.0 |
|
Thanks! You guys rock. |
|
@rorlic I pushed out v0.19.1 with the built files |
|
It is now working as expected. Thanks again. |
When in tagging mode, not multiple (
taggingLabel === false), selectingan item by click was instead calling
taggingFunc(). This fix checksfor this manual selection, whether
ctrl.searchis filled or not andacts accordingly.
closes #1357