-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow/Enable configurations for ng deploy
commands
#17332
Comments
@george43g, thanks for reporting this. Indeed this is a bug which should be trivial to fix. I’ll take a look at it tomorrow! |
Awesome! I'll let some package maintainers know about this. Should result in some cleaner code/setups. Hopefully, the pull request will be merged in soon. |
Previously we only allowed `--project` and `--help` as a valid options. With this change we also allow `--configuration` Fixes #17332
Previously we only allowed `--project` and `--help` as a valid options. With this change we also allow `--configuration` Fixes #17332
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Command (mark with an
x
)Is this a regression?
Probably not
Description
Not sure if this is a bug or a feature request.
Allow specifying a
--configuration='production'
forng deploy
commands.This should simply read from the corresponding configuration and apply those settings on top of settings found in
options
under thedeploy
config.According to docs, this should work for other types of tasks such as build/serve/lint: https://angular.io/guide/cli-builder#target-configuration
🔬 Minimal Reproduction
This command works:
ng deploy myProject
This command does not work, even with correct configuration:
ng deploy myProject --configuration production
🔥 Exception or Error
🌍 Your Environment
Angular CLI 9
The text was updated successfully, but these errors were encountered: