Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): allow configuration options in ng deploy #17336

Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix(@angular/cli): allow configuration options in ng deploy #17336

merged 1 commit into from
Mar 30, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 30, 2020

fix(@angular/cli): allow configuration option in ng deploy

Previously we only allowed --project and --help as a valid options. With this change we also allow --configuration

Fixes #17332

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 30, 2020
@alan-agius4 alan-agius4 requested a review from clydin March 30, 2020 08:02
Previously we only allowed `--project` and `--help` as a valid options. With this change we also allow `--configuration`

Fixes #17332
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will help make ng deploy using @angular/fire be a lot more useful for team's that have staging and production deployments.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2020
@kyliau kyliau merged commit 4d2d6cd into angular:master Mar 30, 2020
@alan-agius4 alan-agius4 deleted the ng-deploy-options branch March 31, 2020 06:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow/Enable configurations for ng deploy commands
5 participants