-
Notifications
You must be signed in to change notification settings - Fork 12k
Decorator stripping for app code no longer working in 1.5.0-rc.0 #8050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
P1
Impacts a large percentage of users; if a workaround exists it is partial or overly painful
type: bug/fix
Comments
May be duplicate of #8027? Because the CLI automatically uses |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 17, 2017
We feel build This PR defualts `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 17, 2017
We feel build This PR defualts `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 17, 2017
We feel build This PR defualts `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 18, 2017
We feel build This PR defualts `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 18, 2017
We feel build This PR defualts `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
filipesilva
added a commit
that referenced
this issue
Oct 18, 2017
We feel build `--build-optimizer` is stable enough to not be experimental anymore. This PR defaults `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix #8050
filipesilva
added a commit
that referenced
this issue
Oct 18, 2017
We feel build `--build-optimizer` is stable enough to not be experimental anymore. This PR defaults `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix #8050
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this issue
Apr 23, 2018
We feel build `--build-optimizer` is stable enough to not be experimental anymore. This PR defaults `build-optimizer` when using Angular 5+ on a production build with `--aot`. It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`). Fix angular#8050
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P1
Impacts a large percentage of users; if a workaround exists it is partial or overly painful
type: bug/fix
Bug Report or Feature Request (mark with an
x
)Versions.
I tested this also with Typescript 2.4.2 and got the same result.
Repro steps.
The log given by the failure.
no error, the app builds, but the bundle contains decorators coming from the app code.
Example:
Desired functionality.
All decorators in the app code should have been stripped.
Mention any other details that might be useful.
This used to work in the past.
The text was updated successfully, but these errors were encountered: