Skip to content

fix(@angular/cli): strip decorators with Angular 5+ #8077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Oct 17, 2017

We feel build --build-optimizer is stable enough to not be experimental anymore.

This PR defualts build-optimizer when using Angular 5+ on a production build with --aot.

It can still be turned off with --no-build-optimizer (or --build-optimizer=false).

Fix #8050

@filipesilva filipesilva self-assigned this Oct 17, 2017
@filipesilva filipesilva requested a review from hansl October 17, 2017 17:23
@filipesilva
Copy link
Contributor Author

filipesilva commented Oct 17, 2017

The releases that include this PR should update @angular-devkit/build-optimizer@^0.0.28 to include angular/devkit#210.

We feel build

This PR defualts `build-optimizer`  when using Angular 5+ on a production build with `--aot`.

It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`).

Fix angular#8050
@filipesilva filipesilva force-pushed the build-opt-default-true branch from 49df5fa to d764518 Compare October 18, 2017 09:54
@filipesilva filipesilva assigned hansl and unassigned filipesilva Oct 18, 2017
@filipesilva filipesilva merged commit 451f17c into angular:master Oct 18, 2017
@filipesilva filipesilva deleted the build-opt-default-true branch October 18, 2017 18:49
filipesilva added a commit that referenced this pull request Oct 18, 2017
We feel build `--build-optimizer` is stable enough to not be experimental anymore.

This PR defaults `build-optimizer`  when using Angular 5+ on a production build with `--aot`.

It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`).

Fix #8050
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 24, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 24, 2017
hansl pushed a commit that referenced this pull request Oct 24, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
We feel build `--build-optimizer` is stable enough to not be experimental anymore.

This PR defaults `build-optimizer`  when using Angular 5+ on a production build with `--aot`.

It can still be turned off with `--no-build-optimizer` (or `--build-optimizer=false`).

Fix angular#8050
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator stripping for app code no longer working in 1.5.0-rc.0
3 participants