feat(@schematics/angular): extend tslint:recommended #13213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Dec 19, 2018
mgechev
reviewed
Dec 20, 2018
| "check-space" | ||
| ], | ||
| "curly": true, | ||
| "adjacent-overload-signatures": false, |
There was a problem hiding this comment.
Looks like in the current CLI and tslint this has value true, lmk if I'm wrong.
There was a problem hiding this comment.
Hmm, I don't think it is present in the current tslint.json, so I guess it's not activated (unless I'm missing something?).
|
|
mgechev
reviewed
Dec 20, 2018
mgechev
requested changes
Dec 20, 2018
Updates the `tslint.json` file to extend to the `tslint:recommended` set. Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.
cexbrayat
force-pushed
the
feat/extend-tslint-recommended
branch
from
23945da to
6d72396
Compare
|
@mgechev good catch: I added |
mgechev
approved these changes
Dec 21, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
tslint.jsonfile to extend to thetslint:recommendedset.Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.
Fixes #6179
cc @mgechev this is to start the discussion, feedback welcome