Skip to content

feat(@schematics/angular): activate recommended tslint rules #13427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

cexbrayat
Copy link
Member

PR #13213 made tslint.json extend tslint:recommended.
As a first step, we deactivated explicitely all rules that were in the recommended set but were not in the old tslint.json file to keep the exact same configuration.

This PR activates a few of the recommended rules that were explicitely deactiviated, making te confoguration closer to the recommended one, and shorter. I tried to keep the "Angular style guide" and chose to activate the ones that I think are not controversial. Let me know what you think.

cc @mgechev

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for two rules.

@cexbrayat cexbrayat force-pushed the feat/tslint-activate-rules branch from ffb4459 to c743e29 Compare January 14, 2019 10:53
@cexbrayat
Copy link
Member Author

@clydin Thanks for the review. For now, I deactivated max-classes-per-file per your feedback and amended the the PR, and I'll remove no-var-require if necessary after my answer on your comment.

@clydin clydin added the target: major This PR is targeted for the next major release label Jan 14, 2019
@cexbrayat cexbrayat force-pushed the feat/tslint-activate-rules branch from c743e29 to c0e5ccc Compare January 14, 2019 17:17
@kyliau kyliau merged commit a52fc53 into angular:master Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants