Skip to content

fix(@angular-devkit/build-angular): show missing karma-coverage error when it's not configured #19361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

alan-agius4
Copy link
Collaborator

This fixes an issue where previously karma-coverage must be installed in order to run code coverage error was shown incorrectly.

Closes: #19359

… when it's not configured

This fixes an issue where previously `karma-coverage must be installed in order to run code coverage` error was shown incorrectly.

Closes: #19359
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 12, 2020
@alan-agius4 alan-agius4 requested a review from clydin November 12, 2020 17:35
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2020
@alan-agius4 alan-agius4 removed the request for review from clydin November 12, 2020 18:52
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Nov 12, 2020
@clydin clydin merged commit 88a3794 into angular:master Nov 12, 2020
@alan-agius4 alan-agius4 deleted the karma-error branch November 12, 2020 18:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to run test with teamcity and coverage-istanbul reporters only? (Angular 11)
3 participants