Skip to content

refactor: update @angular/dev-infra-private package #21855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Oct 1, 2021

This is to unblock the 12.2.8 release with angular/dev-infra#247.

@dgp1130 dgp1130 added the target: major This PR is targeted for the next major release label Oct 1, 2021
@dgp1130 dgp1130 requested a review from josephperrott October 1, 2021 17:31
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Oct 1, 2021

Already being addressed here #21851

Although for the 12.2 release I think you need to backport a number of changes to the to patch branch.

@dgp1130
Copy link
Collaborator Author

dgp1130 commented Oct 1, 2021

Ah, didn't realize the robot beat me to it. I'll merge that one since it's the standard update.

@dgp1130 dgp1130 closed this Oct 1, 2021
@devversion
Copy link
Member

On a related note: Ideally the dev-infra package would have been updated in the patch version as well. I'm not sure why in the past this didn't happen. 12.2.x and master are currently diverged and have different configuration files for .ng-dev.

Usually it's good keeping th build setup in sync for version branches (such as master or 12.2.x).

@dgp1130 dgp1130 deleted the dev-infra-update branch October 1, 2021 21:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants