fix(ng-dev/release): prepare-commit-message hook accidentally running when bump commit is created #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when bump commit is created The `prepare-commit-message` hook can still accidentally run when the changelog / version bump commit is created. This is problematic because when a version branch is checked out (like the patch branch), the node modules are not necessarily updated/re-installed, and the node modules from master remain installed. This can cause runtime errors when Git hooks accidentally run with a tool from the node modules (like `ng-dev` itself). We fix this by also setting the `HUSKY` environment variable, similar to how the merge tool does. We can assume that Husky is used in all repositories. This should be our standard for hooks.
dgp1130
added a commit
to dgp1130/angular-cli
that referenced
this pull request
Oct 1, 2021
This is to unblock the `12.2.8` release with angular/dev-infra#247.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prepare-commit-messagehook can still accidentally run when thechangelog / version bump commit is created. This is problematic because
when a version branch is checked out (like the patch branch), the node
modules are not necessarily updated/re-installed, and the node modules
from master remain installed. This can cause runtime errors when Git
hooks accidentally run with a tool from the node modules (like
ng-devitself).
We fix this by also setting the
HUSKYenvironment variable, similar tohow the merge tool does. We can assume that Husky is used in all
repositories. This should be our standard for hooks.