-
Notifications
You must be signed in to change notification settings - Fork 12k
feat:@angular/cli add support for tsx syntax #8619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I tried to reflect needed changes in all files that were relevant, although I'm not sure if I covered all of the edge cases. Especially in In my opinion we don't need to ensure that the module will be resolved into |
Add support for tsx syntax in component files Closes angular#8046
be59a64
to
47b11b9
Compare
Heya, some tests still seem to be failing. It looks like it's the path resolver. |
@hansl could you have a look? |
I guess this is depending on angular/angular#20556, currently Angular compiler/compiler-cli itself is incompatible with |
Although we should support TSX files, this PR really needs to be updated and cleaned up. Closing this but if you submit a new PR we'll take a look at it. Thanks |
For anyone stumbling upon this, here's the current workaround: https://gist.github.com/majo44/4862b8e7db6254975669e0a3f9d67a2a |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add support for tsx syntax in component files
Closes #8046