Skip to content

feat:@angular/cli add support for tsx syntax #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wholysz
Copy link

@wholysz wholysz commented Nov 24, 2017

Add support for tsx syntax in component files
Closes #8046

@wholysz wholysz requested a review from hansl as a code owner November 24, 2017 09:12
@wholysz
Copy link
Author

wholysz commented Nov 24, 2017

Hello, I tried to reflect needed changes in all files that were relevant, although I'm not sure if I covered all of the edge cases. Especially in packages/@ngtools/webpack/src/lazy_routes.ts#53.

In my opinion we don't need to ensure that the module will be resolved into .tsx, as angular modules are always written in "plain" .ts. If you could, please double check that I'm not wrong 😄

Add support for tsx syntax in component files
Closes angular#8046
@wholysz wholysz force-pushed the cli-build-should-support-tsx branch from be59a64 to 47b11b9 Compare November 24, 2017 10:05
@filipesilva
Copy link
Contributor

Heya, some tests still seem to be failing. It looks like it's the path resolver.

@filipesilva
Copy link
Contributor

@hansl could you have a look?

@trotyl
Copy link
Contributor

trotyl commented Nov 30, 2017

I guess this is depending on angular/angular#20556, currently Angular compiler/compiler-cli itself is incompatible with .tsx file suffix.

@wholysz
Copy link
Author

wholysz commented Dec 6, 2017

@trotyl Thanks! Perhaps you're right. Any ETA for your PR merge? Would love to have it in place :)

@hansl do you find something missing in above changes? The build is failing due to the tests. Can we sync up on gitter regarding this?

@rsxdalv
Copy link

rsxdalv commented Dec 27, 2017

@wholysz @trotyl The upstream PR has been merged

@hansl hansl removed their assignment Feb 8, 2018
@hansl
Copy link
Contributor

hansl commented Feb 22, 2018

Although we should support TSX files, this PR really needs to be updated and cleaned up. Closing this but if you submit a new PR we'll take a look at it. Thanks

@hansl hansl closed this Feb 22, 2018
@rsxdalv
Copy link

rsxdalv commented Feb 22, 2018

For anyone stumbling upon this, here's the current workaround: https://gist.github.com/majo44/4862b8e7db6254975669e0a3f9d67a2a
.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli build should support loading modules with *.tsx extension.
6 participants