Skip to content

fix(compiler): make tsx file aot compatible #20556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Nov 21, 2017

fixes #20555

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #20555

What is the new behavior?

Make Angular compiler supports .tsx files.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@trotyl trotyl changed the title [WIP] fix(compiler-cli): make tsx file aot compatible [WIP] fix(compiler): make tsx file aot compatible Nov 21, 2017
@trotyl trotyl changed the title [WIP] fix(compiler): make tsx file aot compatible fix(compiler): make tsx file aot compatible Nov 21, 2017
@mhevery mhevery requested a review from chuckjaz November 21, 2017 17:25
@mhevery mhevery added the area: core Issues related to the framework runtime label Nov 21, 2017
@trotyl trotyl changed the title fix(compiler): make tsx file aot compatible [WIP] fix(compiler): make tsx file aot compatible Nov 22, 2017
@trotyl trotyl force-pushed the fix-tsx-support branch 3 times, most recently from b24bb5b to 3e250da Compare November 29, 2017 05:53
@trotyl trotyl changed the title [WIP] fix(compiler): make tsx file aot compatible fix(compiler): make tsx file aot compatible Nov 29, 2017
@trotyl
Copy link
Contributor Author

trotyl commented Nov 29, 2017

Ready for review now

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 14, 2017
@alxhub alxhub merged commit 05ff6c0 into angular:master Dec 15, 2017
@trotyl trotyl deleted the fix-tsx-support branch December 27, 2017 08:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression(compiler): new transformer pipeline breaks .tsx support
5 participants